RFR: 8329728: Read long lines in ClassListParser [v5]

Ioi Lam iklam at openjdk.org
Wed Apr 10 17:54:25 UTC 2024


> Today the `ClassListParser` has a hard-coded limit of 4096 chars for each line in the CDS class list file. However, it's possible for a line to be much longer than than (64KB for the class name, plus extra information that can include path names, IDs, etc).
> 
> I wrote a utility class `LineReader` that automatically allocates a buffer before calling `fgets()`. Hopefully this can be useful for other cases where we call `fgets()` with a fixed buffer size.
> 
> Max line width is limited to 4M to simplify testing (and avoid running into corner cases when we approach INT_MAX).

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into 8329728-read-arbitrary-long-lines-in-class-list-parser
 - @dholmes-ora and @calvinccheung comments
 - Check class name for valid UTF8 encoding
 - @matias9927 and @calvinccheung comments - limit line to 4M. Added gtest cases. Test for class names > 64K
 - 8329728: Read arbitrarily long lines in ClassListParser

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18669/files
  - new: https://git.openjdk.org/jdk/pull/18669/files/6471fca1..f6ef76f0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18669&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18669&range=03-04

  Stats: 10071 lines in 337 files changed: 5970 ins; 2426 del; 1675 mod
  Patch: https://git.openjdk.org/jdk/pull/18669.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18669/head:pull/18669

PR: https://git.openjdk.org/jdk/pull/18669


More information about the hotspot-dev mailing list