RFR: 8327946: containers/docker/TestJFREvents.java fails when host kernel config vm.swappiness=0 after JDK-8325139 [v2]

SendaoYan syan at openjdk.org
Thu Apr 11 15:38:43 UTC 2024


On Thu, 11 Apr 2024 09:50:57 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add a space before //
>
> test/hotspot/jtreg/containers/docker/TestJFREvents.java line 225:
> 
>> 223:                                       .addDockerOpts("--memory-swap=" + swapValueToSet)
>> 224:                                       //The default memory-swappiness vaule is inherited from the host machine, which maybe 0
>> 225:                                       .addDockerOpts("--memory-swappiness=60")
> 
> Nit: Space after `//`.
> 
> `--memory-swappiness` is cgroup v1 (legacy specific):
> 
> $ podman run --rm -ti --memory-swappiness=60 fedora:39
> Error: OCI runtime error: crun: cannot set memory swappiness with cgroupv2
> 
> 
> Therefore, we need to ensure we are running on cgroups v1 when we add that option.

Thanks for your review. The space after `//` has been added.

I can't reproduce the "OCI runtime error" failure on mine ubuntu22 environment.
It seems that ubuntu22 use cgroups v2 by default.
![image](https://github.com/openjdk/jdk/assets/24123821/d41934fe-afb4-45a7-abd4-df4070123bb2)

Can you show your host machine enviroment information, so I can reproduce the same failure. After that I will try to find a solution with cgroupv2.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18225#discussion_r1561236762


More information about the hotspot-dev mailing list