RFR: 8329605: hs errfile generic events - introduce sections for Frequent/NotFrequent Events [v3]
Thomas Stuefe
stuefe at openjdk.org
Thu Apr 11 16:02:41 UTC 2024
On Tue, 9 Apr 2024 07:31:23 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Currently the 'generic' hs_errfile Events message log (filled by Events::log) is rather flooded by messages for memory protection operations. Those seem to occur quite often and move out other less frequent events, because the number of entries in the log is limited.
>> It might be better to separate the frequent and less frequent events into 2 sections. The memory protection events would go into the frequent events section.
>> The mentioned memory protection operations related entries look like this :
>> Event: 0.178 Protecting memory [0x000000016ebf0000,0x000000016ebfc000] with protection modes 0
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> adjust typo
Hmm, I think the separation makes sense, but I don't like the "frequent" moniker. All other event logs are separated by thematic area. "frequent" is orthogonal to that. I can have frequent/non-frequent class loading messages, or exceptions.
My proposal would be either to drop these memory protection events (do we need them? or are they remnants of some old support issues?) or to put them into a 'memprot' section or similar.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18626#issuecomment-2050026608
More information about the hotspot-dev
mailing list