RFR: 8329757: Crash with fatal error: DEBUG MESSAGE: Fast Unlock lock on stack [v3]

[Axel Boldt-Christmas]

On Thu, 11 Apr 2024 17:19:56 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Why lightweight locking verification code (old and new) is under `#ifndef PRODUCT` instead of `#ifdef ASSERT`? Asserts are enabled only in debug VM (when ASSERT is defined).

I think it was mostly convenience and an oversight from my part. Did not think about the exact interactions. But it does look strange to call a function that does nothing but spin around in a loop for some cycles. I will separate out the new verification code put it behind  `ASSERT` instead.

As for the old LockStack verification, I do not know. I was not involved with this back when it was integrated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18715#issuecomment-2050241132