RFR: 8328934: Assert that ABS input and output are legal [v3]

Aleksey Shipilev shade at openjdk.org
Fri Apr 12 09:21:54 UTC 2024


> This should protect us from future accidents around `abs` misuse. We have fixed a few separately. I plan to use this as the litmus test in update releases to detect missing backports for actual fixes. I am running more tests to see if we have any other sightings in current codebase, but this can be reviewed for sanity meanwhile.
> 
> Additional testing:
>  - [x] MacOS AArch64 server fastdebug build passes
>  - [ ] Linux x86_64 server fastdebug, `all`
>  - [ ] Linux x86_64 server fastdebug, 100K Fuzzer tests
>  - [ ] Linux x86_64 server fastdebug, Maven CTW
>  - [ ] Linux AArch64 server fastdebug, `all`

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

  Only assert integral type arguments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18751/files
  - new: https://git.openjdk.org/jdk/pull/18751/files/59f3aaab..730b18af

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18751&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18751&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18751.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18751/head:pull/18751

PR: https://git.openjdk.org/jdk/pull/18751


More information about the hotspot-dev mailing list