RFR: 8327946: containers/docker/TestJFREvents.java fails when host kernel config vm.swappiness=0 after JDK-8325139 [v4]
SendaoYan
syan at openjdk.org
Fri Apr 12 15:32:42 UTC 2024
On Fri, 12 Apr 2024 10:14:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> Better. I don't think we need to duplicate that much of the test. All we'd need to do is to add the `--memory-swappiness` option only if we are on cg v1:
>
> ```
> opts.addDockerOpts("--memory=" + memValueToSet)
> .addDockerOpts("--memory-swap=" + swapValueToSet)
> .addClassOptions("jdk.SwapSpace"));
> if (isCgroupV1) {
> // With Cgroupv1, The default memory-swappiness vaule is inherited from the host machine, which maybe 0
> opts.addDockerOpts("--memory-swappiness=60");
> }
> out = DockerTestUtils.dockerRunJava(opts);
> ...
> ```
Thank you very much for your very professional opinions. The modification of the review opinions has been completed. In addition, an extra space at the beginning of the line was deleted.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18225#issuecomment-2051985003
More information about the hotspot-dev
mailing list