RFR: 8330161: RISC-V: Don't use C for Labels jumps
Fei Yang
fyang at openjdk.org
Mon Apr 15 07:17:41 UTC 2024
On Mon, 15 Apr 2024 06:46:19 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Then I suggest we remove jalr from the method.
>
> Note, I notice this when I enable c_jal, if we ever want c_jal we need to either eanble patching of C or turn off C when we need patching.
> Then I suggest we remove jalr from the method.
I think we still need the `jalr` which is emitted by the else block of the method. The reason is that we have calls to `void jal(const address dest, Register temp = t0);` where we need to check whether `dest` is far or not [1][2].
[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp#L1815
[2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp#L3532
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18761#discussion_r1565280510
More information about the hotspot-dev
mailing list