RFR: 8328934: Assert that ABS input and output are legal [v5]

Aleksey Shipilev shade at openjdk.org
Mon Apr 15 07:59:07 UTC 2024


> This should protect us from future accidents around `abs` misuse. We have fixed a few separately. I plan to use this as the litmus test in update releases to detect missing backports for actual fixes. I am running more tests to see if we have any other sightings in current codebase, but this can be reviewed for sanity meanwhile.
> 
> Additional testing:
>  - [x] MacOS AArch64 server fastdebug build passes
>  - [ ] Linux x86_64 server fastdebug, `all`
>  - [ ] Linux x86_64 server fastdebug, 100K Fuzzer tests
>  - [ ] Linux x86_64 server fastdebug, Maven CTW
>  - [ ] Linux AArch64 server fastdebug, `all`

Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:

 - Also tests
 - Drop the other check; dodge UB

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18751/files
  - new: https://git.openjdk.org/jdk/pull/18751/files/f3d75b39..3f6d76f3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18751&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18751&range=03-04

  Stats: 124 lines in 2 files changed: 116 ins; 5 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18751.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18751/head:pull/18751

PR: https://git.openjdk.org/jdk/pull/18751


More information about the hotspot-dev mailing list