RFR: 8328934: Assert that ABS input and output are legal [v4]

[Aleksey Shipilev]

On Fri, 12 Apr 2024 10:05:55 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> This should protect us from future accidents around `abs` misuse. We have fixed a few separately. I plan to use this as the litmus test in update releases to detect missing backports for actual fixes. I am running more tests to see if we have any other sightings in current codebase, but this can be reviewed for sanity meanwhile.
>> 
>> Additional testing:
>>  - [x] MacOS AArch64 server fastdebug build passes
>>  - [ ] Linux x86_64 server fastdebug, `all`
>>  - [ ] Linux x86_64 server fastdebug, 100K Fuzzer tests
>>  - [ ] Linux x86_64 server fastdebug, Maven CTW
>>  - [ ] Linux AArch64 server fastdebug, `all`
>
> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - More straightforward
>  - Richer error reporting

Testing update:

I ran Maven CTW tests, Fuzzer tests, the entirety of JDK codebase, and I believe the only thing we are missing is [JDK-8330158](https://bugs.openjdk.org/browse/JDK-8330158). After that fix lands, we can integrate this patch, which would hopefully seal against introducing new bugs.

I also added a direct gtest for ABS.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18751#issuecomment-2056006999