RFR: 8330094: RISC-V: Save and restore FCSR in the call stub [v2]
Hamlin Li
mli at openjdk.org
Mon Apr 15 16:30:14 UTC 2024
On Mon, 15 Apr 2024 16:07:17 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - update comment accordingly
>> - skip setting frm when not needed
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 308:
>
>> 306: Label skip_fsrmi;
>> 307: __ mv(t1, __ RoundingMode::rne);
>> 308: __ beq(t0, t1, skip_fsrmi);
>
> You can take advantage of `RoundingMode::rne == 0` by doing `__ beq(t0, zr, skip_fsrmi)` and remove the above `__ mv(t1, __ RoundingMode::rne);`. Please add a `guarantee(__ RoundingMode::rne == 0)` as well, just to self-document.
Thanks, fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18758#discussion_r1566084779
More information about the hotspot-dev
mailing list