RFR: 8180450: secondary_super_cache does not scale well [v14]

Vladimir Ivanov vlivanov at openjdk.org
Mon Apr 15 20:52:02 UTC 2024


On Mon, 15 Apr 2024 13:49:20 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/share/cds/filemap.hpp line 274:
>> 
>>> 272:   bool compressed_oops()                   const { return _compressed_oops; }
>>> 273:   bool compressed_class_pointers()         const { return _compressed_class_ptrs; }
>>> 274:   bool use_secondary_supers_table()        const { return _use_secondary_supers_table; }
>> 
>> Do we really need this accessor which is used only in one place?
>
> @iwanowww , this one is yours. May I nuke this method?

Sure. I don't have a strong opinion about it. It's cleaner to access fields through the accessor, but I agree that it doesn't add much value in its current form.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18309#discussion_r1566422162


More information about the hotspot-dev mailing list