RFR: 8329088: Stack chunk thawing races with concurrent GC stack iteration [v2]

[Erik Österlund]

On Fri, 12 Apr 2024 15:07:03 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Nits
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 567:
> 
>> 565:   // Consider leaving the chunk's argsize set when emptying it and removing the following branch,
>> 566:   // although that would require changing stackChunkOopDesc::is_empty
>> 567:   if (!chunk->is_empty()) {
> 
> Seems you have implemented the suggestion in the comment so we can remove this branch and unconditionally decrement total_size_needed.

I currently have an assert that checks that you shouldn't be asking for the argsize() if the chunk is empty, because it is so error prone. I think I'd like to keep the assert though - it was quite useful.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18643#discussion_r1567032762