RFR: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier [v7]
kuaiwei
duke at openjdk.org
Tue Apr 16 12:57:00 UTC 2024
On Tue, 16 Apr 2024 09:10:38 GMT, Andrew Haley <aph at openjdk.org> wrote:
> > > Hi, I guess this isn't quite ready for review let. I'll have another look whan it is.
> >
> >
> > Is there any other gap I'm not aware?
>
> Well, you're asking me to speculate on what you're aware of, but the very first thing I see when I run "java -version" with this patch is this, so I assume you're not finished.
>
> ```
> 0x0000ffffe8ad2750: str w11, [x0, #0x14] ;*invokespecial <init> {reexecute=0 rethrow=0 return_oop=0}
> ; - java.lang.StringLatin1::replace at 123 (line 427)
> ;; membar_release
> 0x0000ffffe8ad2754: dmb ishld
> 0x0000ffffe8ad2758: dmb ishst ;*new {reexecute=0 rethrow=0 return_oop=0}
> ; - java.lang.StringLatin1::replace at 116 (line 427)
> ;; membar_release
> 0x0000ffffe8ad275c: dmb ishld
> 0x0000ffffe8ad2760: dmb ishst ;*synchronization entry
> ; - java.lang.StringLatin1::replace at -1 (line 408)
> ```
I verified and not reproduced the error. Last week I rebase the patch to resolve a conflict with master branch. I think the error may be caused by apply the patch to old base.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18467#issuecomment-2059024841
More information about the hotspot-dev
mailing list