RFR: 8312132: Add tracking of multiple address spaces in NMT [v5]
Thomas Stuefe
stuefe at openjdk.org
Wed Apr 17 06:50:03 UTC 2024
On Mon, 25 Mar 2024 10:10:34 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> I tend to not use operator-overloading so I didn't think of that as a possibility.
>
> One annoying part about such a design is that you can't use pointers to values as keys, they must now be wrapped within their own type (like `StackIndex` does). Yes, there's a bit of a smell of YAGNI here, but at least `std::set` agrees with me on `Compare` being a template argument.
Could the comparator be a funktor then? Something with a static compare function?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1568227233
More information about the hotspot-dev
mailing list