RFR: 8312132: Add tracking of multiple address spaces in NMT [v34]

[Thomas Stuefe]

On Wed, 17 Apr 2024 06:39:20 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Style, copyright
>
> src/hotspot/share/nmt/nmtTreap.hpp line 66:
> 
>> 64:     LEQ // <=
>> 65:   };
>> 66: 
> 
> Both split and merge use recursion, which worries me, since it is not limited in any way I can see. And I think we can rely on the compiler doing tail recursion optimization. Could a degenerated tree cause stack overflows? Can we do this without recursion?

Hint: test with a rng that returns +1 of last return. Lets see how the tree copes with that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1568302894