RFR: 8330094: RISC-V: Save and restore FRM in the call stub [v3]

[Hamlin Li]

On Wed, 17 Apr 2024 03:55:34 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine code
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 304:
> 
>> 302:     __ frrm(t0);
>> 303:     __ sd(t0, frm_save);
>> 304:     // Set fcsr to the state we need. We do want Round to Nearest. We
> 
> I think it will be more accurate to mention `frm` instead of `fcsr` in both code comment and the JBS title?

agree, fixed

> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 308:
> 
>> 306:     Label skip_fsrmi;
>> 307:     guarantee(__ RoundingMode::rne == 0, "must be");
>> 308:     __ beq(t0, zr, skip_fsrmi);
> 
> Suggestion: `__ beqz(t0, skip_fsrmi);`

fixed, thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18758#discussion_r1568338049
PR Review Comment: https://git.openjdk.org/jdk/pull/18758#discussion_r1568338079