RFR: 8330008: [s390x] Test bit "in-memory" in case of DiagnoseSyncOnValueBasedClasses

Lutz Schmidt lucy at openjdk.org
Wed Apr 17 11:17:42 UTC 2024


On Wed, 10 Apr 2024 09:58:55 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> It's trivial update to use `testbit` method to test the bit "in-memory"

Program logic is changed. You should at least run tests with DiagnoseSyncOnValueBasedClasses != 0 to verify the code still does what it is supposed to do. GHAs don't help here because the change is s390-specific. A second review would be good as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18709#issuecomment-2061019296


More information about the hotspot-dev mailing list