RFR: 8325469: Freeze/Thaw code can crash in the presence of OSR frames [v3]

Patricio Chilano Mateo pchilanomate at openjdk.org
Wed Apr 17 16:21:04 UTC 2024


On Wed, 10 Apr 2024 18:06:33 GMT, Ron Pressler <rpressler at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use WhiteBox to verify OSR compilation
>
> It may be hard to do a proper measurement because the number of methods in our microbenchmarks is small. We're also talking an extra branch, I think. This is code than can be called a million times per second per core. It's very performance sensitive. So I would prefer to first see if there's an impact on nmethod size, and only if there is consider whether the speed implications are acceptable.

Thanks for the reviews @pron and @dean-long!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18637#issuecomment-2061695741


More information about the hotspot-dev mailing list