RFR: 8320522: Remove code related to `RegisterFinalizersAtInit` [v3]
Dan Heidinga
heidinga at openjdk.org
Wed Apr 17 20:38:34 UTC 2024
On Wed, 17 Apr 2024 20:08:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Dan Heidinga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update ppc template comment too
>
> src/hotspot/share/classfile/classFileParser.cpp line 4191:
>
>> 4189: // See documentation of InstanceKlass::can_be_fastpath_allocated().
>> 4190: assert(ik->size_helper() > 0, "layout_helper is initialized");
>> 4191: if (ik->is_abstract() || ik->is_interface()
>
> TIL what this bit was. There are some comments in the interpreters that claim that the bit will be set if there are finalizers, which is no longer true. The comments look like:
>
> // test to see if it has a finalizer or is malformed in some way
Thanks. I never would have found that!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18823#discussion_r1569506975
More information about the hotspot-dev
mailing list