RFR: 8330253: Skip verify_consistent_lock_order when deoptimizing from monitorenter bytecode. [v2]

[Axel Boldt-Christmas]

On Wed, 17 Apr 2024 16:58:56 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Handle previous bc being monitorenter
>>  - Remove implicit conditions
>
> src/hotspot/share/runtime/deoptimization.cpp line 451:
> 
>> 449:                                       chunk->first()->raw_bci() == SynchronizationEntryBCI;
>> 450:     // If deoptimizing from monitorenter bytecode we maybe in transitional state. Skip verification.
>> 451:     // When reexecuting the current bc, the previous bc may not have finished yet.
> 
> Should this:
> `... the previous bc may not have finished yet.`
> be:
> `... the previous monitorenter bc may not have finished yet.`

Yeah, while both statements are true, the later is more specific to this context. Which  is probably better and more clear.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18782#discussion_r1570002854