RFR: 8330156: RISC-V: Range check auipc + signed 12 imm instruction [v3]
Hamlin Li
mli at openjdk.org
Thu Apr 18 07:55:58 UTC 2024
On Mon, 15 Apr 2024 10:08:59 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi please consider!
>>
>> Today we check if the distance is a signed 32.
>> As the second instruction have sign bit + 11 bits the, max of such pair is shorter.
>>
>> Sanity tested
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>
> Non inclusive positive side
Looks good.
Just one minor suggestion, the name *in_range_auipc_`s12`* seems could be improved a bit, maybe something like `is_valid_auipc_offset` could be better?
-------------
Marked as reviewed by mli (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18755#pullrequestreview-2008121357
More information about the hotspot-dev
mailing list