RFR: 8330156: RISC-V: Range check auipc + signed 12 imm instruction [v4]
Hamlin Li
mli at openjdk.org
Thu Apr 18 13:19:01 UTC 2024
On Thu, 18 Apr 2024 12:11:42 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename
>
> TBH, I don't really like this new name `is_valid_auipc_offset` which I think could be misleading. Because it's not an offset for solely `auipc`. I prefer names like `is_valid_32bit_offset` or `riscv_insn_valid_32bit_offset` which is similar to the one in linux. But I will let you guys decide :-)
Seems @RealFYang 's suggestion is better, but I'm fine with either of these versions, as long as no `s12`. :)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18755#issuecomment-2063844960
More information about the hotspot-dev
mailing list