RFR: 8330253: Skip verify_consistent_lock_order when deoptimizing from monitorenter bytecode. [v3]

[Daniel D. Daugherty]

On Thu, 18 Apr 2024 05:38:24 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> The verification added in [JDK-8329757](https://bugs.openjdk.org/browse/JDK-8329757) will not work then deoptimization occurs on a monitorenter bytecode. The locking may be in a transitional state. This patch will skip the verification when this occurs.
>> 
>> Currently have only seen this reproduce with JVMTI when deoptimization occurs while a java thread is waiting on a contended monitor. However this could potentially be triggered from a VM entry slow path, so simply checking `current_pending_monitor` could be flaky as well. So instead simply avoid verification.
>> 
>> Running JVMTI reproducer. Starting full testing soon.
>
> Axel Boldt-Christmas has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Whitespace
>  - Spelling and typos

Thumbs up on the changes themselves.

Unless I missed it, I haven't seen updated info on the pre-integration testing
in general and specifically about whether Tier8 was executed.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18782#pullrequestreview-2009157370