RFR: 8330253: Skip verify_consistent_lock_order when deoptimizing from monitorenter bytecode. [v3]

Thu Apr 18 19:19:01 UTC 2024

On Thu, 18 Apr 2024 05:38:24 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> The verification added in [JDK-8329757](https://bugs.openjdk.org/browse/JDK-8329757) will not work then deoptimization occurs on a monitorenter bytecode. The locking may be in a transitional state. This patch will skip the verification when this occurs.
>> 
>> Currently have only seen this reproduce with JVMTI when deoptimization occurs while a java thread is waiting on a contended monitor. However this could potentially be triggered from a VM entry slow path, so simply checking `current_pending_monitor` could be flaky as well. So instead simply avoid verification.
>> 
>> Running JVMTI reproducer. Starting full testing soon.
>
> Axel Boldt-Christmas has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Whitespace
>  - Spelling and typos

I was playing with a reproducer, maybe it would be good to add it: https://github.com/pchilano/jdk/commit/77a85a0ea0dd650929799d8546322d31b69f92e6

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18782#issuecomment-2065011998