RFR: 8330266: RISC-V: Restore frm to RoundingMode::rne after JNI
Robbin Ehn
rehn at openjdk.org
Fri Apr 19 09:00:57 UTC 2024
On Thu, 18 Apr 2024 13:26:32 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch?
> It's exactly the same as https://github.com/openjdk/jdk/pull/18785 which is withdrawn, the reason could be that I deleted the branch `restore-frm-after-jni` after I `/integrate` the pr, but in fact the deletion happened before it's indeed integrated by github, so it caused the withdraw.
> Sorry for the inconvenience.
>
> Thanks
Thanks!
But the flag RestoreMXCSROnJNICalls is actually "x86 specific".
We should add a new flag that alias this, such as "RestoreFPModeOnJNICalls". Or whatever is good generic name.
-------------
Marked as reviewed by rehn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18839#pullrequestreview-2010907026
More information about the hotspot-dev
mailing list