RFR: 8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

[Daniel D. Daugherty]

On Wed, 17 Apr 2024 16:49:25 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> This is a 3rd attempt of the same fix:
> 
> 1st one had to be pulled out because of a bug in zsh
> 2nd one had a workaround for the bug in zsh, but then uncovered an issue in JWDP (JDK-8324668), which was subsequently fixed.
> 
> Tested with MACH5 tier1-9 with no unique or new failures on macOS

I compared this patch to the previous patch (8300088) and it is the
same in the core part of the fix. All but one of the editorial changes
from 8300088 have been dropped which is good for a backport.

It would be good if you revived all of the editorial fixes from 8300088
and integrated them into the main line using a separate RFE.

Thanks for documenting your testing.

src/hotspot/os/bsd/os_bsd.cpp line 2136:

> 2134: 
> 2135:   if (MaxFDLimit) {
> 2136:     // Set the number of file descriptors to max. print out error

You dropped the other editorial fixed, but only kept part of this one. In the previous
version of patch (8300088), you also fixed: s/print/Print/

I would drop this editorial fix also.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18821#pullrequestreview-2013099071
PR Review Comment: https://git.openjdk.org/jdk/pull/18821#discussion_r1573305188