RFR: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier [v7]
kuaiwei
duke at openjdk.org
Mon Apr 22 11:18:29 UTC 2024
On Wed, 17 Apr 2024 02:08:58 GMT, kuaiwei <duke at openjdk.org> wrote:
> > Argh, I found it. It happens because C2 calls `masm->offset()` from `PhaseOutput::fill_buffer()` after every node is emitted. So that trick isn't going to work.
> > It was worth a try, but given that C2 expects offset() to be correct after every node, I think we're stuck. Maybe the last idea you had is the best possible without C2 tinkering.
>
> got it. I will check if we can make offset() work with fill_buffer. Or I will rollback the change of offset().
I rolled back the offset() change.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18467#issuecomment-2069129064
More information about the hotspot-dev
mailing list