RFR: 8330253: Skip verify_consistent_lock_order when deoptimizing from monitorenter bytecode. [v6]
Dean Long
dlong at openjdk.org
Mon Apr 22 21:41:31 UTC 2024
On Mon, 22 Apr 2024 21:33:49 GMT, Dean Long <dlong at openjdk.org> wrote:
>> I thought the original check was fine. Could you elaborate on these 2 cases, I didn't really get them.
>
> Deoptimization is already expensive, and this edge case is rare, so I think it would be better to compute the actual previous bytecode here, and not use bci - 1.
Other debug checks in deoptimization compute oop maps, which have to iterate all the bytecodes, so doing it here also wouldn't be so bad. Or how about not checking bytecodes and instead checking a flag on JavaThread that says we are in monitor enter native code?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18782#discussion_r1575385975
More information about the hotspot-dev
mailing list