RFR: 8330578: The VM creates instance of abstract class VirtualMachineError [v7]

[Dean Long]

On Mon, 22 Apr 2024 18:10:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> It's a bug that the VM creates an instance of the abstract class VirtualMachineError.  In the cases where we throw VME, we should throw OOM or StackOverflowError instead.
>> 
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - restore exceptions.cpp comment
>  - Restore VirtualMemoryError as InternalError - a nonabstract class

src/hotspot/share/classfile/verifier.cpp line 258:

> 256:         // to infinitely recurse when we try to initialize the exception.
> 257:         // So bail out here by throwing the preallocated VM error.
> 258:         THROW_OOP_(Universe::class_init_stack_overflow_error(), false);

Should this be InternalError now?  That seems better than StackOverflow.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18847#discussion_r1575400037