RFR: 8330532: Improve line-oriented text parsing in HotSpot [v3]

[John R Rose]

On Tue, 23 Apr 2024 18:31:27 GMT, John R Rose <jrose at openjdk.org> wrote:

>> src/hotspot/share/utilities/istream.hpp line 98:
>> 
>>> 96: 
>>> 97:   Input* _input;   // where the input comes from or else nullptr
>>> 98:   IState _input_state;  // one of {NTR,EOF,ERR}_STATE
>> 
>> This comment not necessary as the type describes its valid state.
>
> Sometimes redundant comments are helpful.  I think this one is.  YMMV.

The `override` keyword is nice; thank you.

I have already argued against the removal of `set_input`.  And `set_input` needs `close`.

I think `set_input` is not YAGNI but YIWNI = Yes I will need it.  The reply that “you can just wrap another i-stream around the new i-source” is fallacious because of the performance model of i-stream.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18833#discussion_r1576724065