RFR: 8331098: [Aarch64] Fix crash in Arrays.equals() intrinsic with -CCP [v2]

Andrew Haley aph at openjdk.org
Fri Apr 26 13:04:20 UTC 2024


On Fri, 26 Apr 2024 10:02:53 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Yes, exactly. Perhaps makes sense to rename the variable to 'base_is_8aligned' or something similar?

With a comment. "Either the base or the length is at an 8-byte-aligned address." This boolean tells you which, and because "reasons" we're trying to maintain alignment. I implore you to measure the difference from alignment, and if the read alignment makes little or no difference, don't do this micro-optimization.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18948#discussion_r1581005798


More information about the hotspot-dev mailing list