RFR: 8328934: Assert that ABS input and output are legal [v6]
Aleksey Shipilev
shade at openjdk.org
Mon Apr 29 08:18:51 UTC 2024
> This should protect us from future accidents around `abs` misuse. We have fixed a few separately. I plan to use this as the litmus test in update releases to detect missing backports for actual fixes. I am running more tests to see if we have any other sightings in current codebase, but this can be reviewed for sanity meanwhile.
>
> Additional testing:
> - [x] MacOS AArch64 server fastdebug build passes
> - [ ] Linux x86_64 server fastdebug, `all`
> - [ ] Linux x86_64 server fastdebug, 100K Fuzzer tests
> - [ ] Linux x86_64 server fastdebug, Maven CTW
> - [ ] Linux AArch64 server fastdebug, `all`
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
- Merge branch 'master' into JDK-8328934-abs-legal
- Also tests
- Drop the other check; dodge UB
- More straightforward
- Richer error reporting
- Only assert integral type arguments
- Need explicit include as well
- Fix
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18751/files
- new: https://git.openjdk.org/jdk/pull/18751/files/3f6d76f3..bc3bfe81
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18751&range=05
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18751&range=04-05
Stats: 74590 lines in 2141 files changed: 33127 ins; 33156 del; 8307 mod
Patch: https://git.openjdk.org/jdk/pull/18751.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18751/head:pull/18751
PR: https://git.openjdk.org/jdk/pull/18751
More information about the hotspot-dev
mailing list