RFR: 8312132: Add tracking of multiple address spaces in NMT [v46]

[Johan Sjölen]

On Tue, 23 Apr 2024 12:51:38 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove faulty condition after removing merging
>>  - Add failing test case
>
> src/hotspot/share/nmt/nmtMemoryFileTracker.cpp line 48:
> 
>> 46:   NativeCallStackStorage::StackIndex sidx = _stack_storage.push(stack);
>> 47:   DeviceSpace::Metadata metadata(sidx, flag);
>> 48:   DeviceSpace::SummaryDiff diff = device->_tree.reserve_mapping(offset, size, metadata);
> 
> What if `size == 0`?

Added test, tree should handle it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1582722773