RFR: 8330253: Remove verify_consistent_lock_order [v8]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Mon Apr 29 14:14:10 UTC 2024
On Mon, 29 Apr 2024 13:52:23 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> The verification added in [JDK-8329757](https://bugs.openjdk.org/browse/JDK-8329757) will not work when deoptimization occurs on a monitorenter bytecode. The locking may be in a transitional state. Because the correct solution is still not obvious and this test is currently only causing false positives, remove the verification for now.
>>
>> Redo this verification in [JDK-8331307](https://bugs.openjdk.org/browse/JDK-8331307).
>
> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>
> - Merge tag 'jdk-23+20' into JDK-8330164
>
> Added tag jdk-23+20 for changeset 87e864bf
> - Revert verification
> - Revert "repro for JDK-8330253"
>
> This reverts commit 10d70ea18c5bad0627b9eaae88fa8c96e436cb3b.
> - Fix condition
> - Use raw bytecode read for previous bytecode
> - repro for JDK-8330253
> - Whitespace
> - Spelling and typos
> - Handle previous bc being monitorenter
> - Remove implicit conditions
> - ... and 1 more: https://git.openjdk.org/jdk/compare/d20db530...d913ecbe
Marked as reviewed by pchilanomate (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/18782#pullrequestreview-2028638432
More information about the hotspot-dev
mailing list