RFR: 8328934: Assert that ABS input and output are legal [v6]

[Dean Long]

On Mon, 29 Apr 2024 08:18:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> This should protect us from future accidents around `abs` misuse. We have fixed a few separately. I plan to use this as the litmus test in update releases to detect missing backports for actual fixes. I am running more tests to see if we have any other sightings in current codebase, but this can be reviewed for sanity meanwhile.
>> 
>> Additional testing:
>>  - [x] MacOS AArch64 server fastdebug build passes
>>  - [x] Linux x86_64 server fastdebug, `all`
>>  - [x] Linux x86_64 server fastdebug, 100K Fuzzer tests
>>  - [x] Linux x86_64 server fastdebug, Maven CTW
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8328934-abs-legal
>  - Also tests
>  - Drop the other check; dodge UB
>  - More straightforward
>  - Richer error reporting
>  - Only assert integral type arguments
>  - Need explicit include as well
>  - Fix

Yes, still good.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18751#issuecomment-2083839172