RFR: 8331360: RISCV: u32 _partial_subtype_ctr loaded/stored as 64

Tue Apr 30 08:21:04 UTC 2024

On Tue, 30 Apr 2024 07:30:21 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Good catch. Looks good!

Thanks!

> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 3347:
> 
>> 3345: 
>> 3346: #ifndef PRODUCT
>> 3347:   incrementw(ExternalAddress((address)&SharedRuntime::_partial_subtype_ctr));
> 
> I just checked the x86 and aarch64 counterpart. Seems that aarch64 bears the same issue [1] as it uses `ldr` / `str` which load / store 64-bit data items like here.
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L1565

I'll open a separate PR, and maybe fix it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19010#issuecomment-2084681630
PR Review Comment: https://git.openjdk.org/jdk/pull/19010#discussion_r1584334544