RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v2]
Fei Yang
fyang at openjdk.org
Tue Apr 30 13:49:05 UTC 2024
On Tue, 30 Apr 2024 10:33:45 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> I have not looked at it in detail.
>>
>> As mnemonic for **call** is _auipc_ + _jalr_, in hotspot `la()` + `jalr()`.
>> So sites using call() for non-code-cache was changed to rt_call(), which gets us the same result as the old call().
>>
>> Hence this patch 'tries' to keep the generate assembly the same.
>
> Make sense?
I am still think about the possibility of unifying `call` and `rt_call`. Having both of them could be confusing to me (and new comers I guess). What I am talking about in my previous comment was something like this add-on change:
[addon.diff.txt](https://github.com/openjdk/jdk/files/15164874/addon.diff.txt)
What do you think?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1584856424
More information about the hotspot-dev
mailing list