RFR: 8312132: Add tracking of multiple address spaces in NMT [v54]

Gerard Ziemski gziemski at openjdk.org
Tue Apr 30 15:17:10 UTC 2024


On Tue, 30 Apr 2024 09:58:32 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> @gerard-ziemski I originally chose "VMA" because its a clearly defined acronym in linux and has close pendants in other OSes as well. I like its brevity. 
>> 
>> If we really want to rename it, I would name it something like `IntervalTree`. Since that's what it really is - managing sets of numeric intervals with attributes. But IMHO VMATree is fine.
>
>>If we really want to rename it, I would name it something like IntervalTree. Since that's what it really is - managing sets of numeric intervals with attributes. But IMHO VMATree is fine.
> 
> I prefer `VMATree` because a traditional interval tree as per Wikipedia doesn't perform any sort of merging, it's "just" a set of intervals.
> 
> If we do expand VMA it should naively be `VirtualMemoryAreaTree`.

A google search for `VMATree` is not very revealing. Anyone new to this area, will be left wondering what this data structure is (I was).

I vote for more flushed out name that gets the reader pointed in the right direction (google search on `VirtualMemoryAreaTree` looks more promising).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1585009962


More information about the hotspot-dev mailing list