RFR: 8335059: Consider renaming ClassLoaderData::keep_alive [v2]

Stefan Karlsson stefank at openjdk.org
Thu Aug 1 06:47:39 UTC 2024


On Thu, 1 Aug 2024 05:07:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename to keep_alive_ref_count
>
> src/hotspot/share/classfile/classLoaderDataGraph.cpp line 313:
> 
>> 311:   while (ClassLoaderData* cld = iter.get_next()) {
>> 312:     // Keep the holder alive.
>> 313:     cld->keep_alive();
> 
> Does comment need changing or removing?

I agree. There's no need to talk about the holder here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20408#discussion_r1699524549


More information about the hotspot-dev mailing list