RFR: 8336163: Remove declarations of some debug-only methods in release build [v2]
Eric Liu
eliu at openjdk.org
Thu Aug 1 06:53:33 UTC 2024
On Thu, 11 Jul 2024 07:12:35 GMT, Qizheng Xing <qxing at openjdk.org> wrote:
>> Some of the methods are defined only in debug mode, but their declarations still exist in release mode.
>>
>> This is considered a bug because these methods may be called mistakenly in release mode and cause the build to fail.
>
> Qizheng Xing has updated the pull request incrementally with one additional commit since the last revision:
>
> Update copyright.
src/hotspot/share/runtime/registerMap.hpp line 159:
> 157: void print_on(outputStream* st) const;
> 158: void print() const;
> 159: #endif
They can be merged into a single MACRO with line 165.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20131#discussion_r1699531407
More information about the hotspot-dev
mailing list