RFR: 8335059: Consider renaming ClassLoaderData::keep_alive [v2]

Coleen Phillimore coleenp at openjdk.org
Thu Aug 1 12:27:33 UTC 2024


On Thu, 1 Aug 2024 06:38:03 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename to keep_alive_ref_count
>
> src/hotspot/share/classfile/classLoaderData.hpp line 215:
> 
>> 213: 
>> 214:  private:
>> 215:   bool keep_alive_ref_count() const { return _keep_alive_ref_count; }
> 
> keep_alive_ref_count() should return an int. The Windows GHA build complains about this.

I don't know why the linux compiler I used didn't, but fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20408#discussion_r1700050506


More information about the hotspot-dev mailing list