RFR: 8337654: Relocate uncommon trap stub from SharedRuntime to OptoRuntime [v3]

[Vladimir Ivanov]

On Thu, 1 Aug 2024 21:58:51 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Reorganization of generation and management code for C2-specific blob so that it is, as far as possible, under the scope of class OptoRuntime with an implementation located in C2-specific source files.
>
> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add new riscv source

Looks good.

src/hotspot/cpu/aarch64/runtime_aarch64.cpp line 219:

> 217:   // crud.  We cannot block on this call, no GC can happen.  Call should
> 218:   // restore return values to their stack-slots with the new SP.
> 219:   // Thread is in rdi already.

It's weird to see `rdi` being mentioned in AArch64-specific code :-)

-------------

Marked as reviewed by vlivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20417#pullrequestreview-2214250900
PR Review Comment: https://git.openjdk.org/jdk/pull/20417#discussion_r1701019269