RFR: 8322770: Implement C2 VectorizedHashCode on AArch64

Mikhail Ablakatov duke at openjdk.org
Fri Aug 2 15:30:35 UTC 2024


On Fri, 2 Aug 2024 15:00:38 GMT, Andrew Haley <aph at openjdk.org> wrote:

> What is going on with C2_MacroAssembler::arrays_hashcode_elsize? It's a change that should not be in this patch.

It was a part of a cleanup. `C2_MacroAssembler::arrays_hashcode_elsize` was added by this PR, it's not present in [openjdk:master](https://github.com/openjdk/jdk/tree/master). JIC, please note that [mikabl-arm:285826-vmul-squashed](https://github.com/mikabl-arm/jdk/tree/285826-vmul-squashed) includes two commits: https://github.com/mikabl-arm/jdk/commit/f19203015fb69e50636bdfa597c7aa48176a56cc presented in the PR and https://github.com/mikabl-arm/jdk/commit/3a52c7f89c293b79559201149f3159d5a8c831b6 / `HEAD` that develops further on the current state of the PR.

> Please take out every change that either does nothing or duplicates functionality that already exists. See type2aelembytes.

May I suggest  to remove all *clenaup* changes from [mikabl-arm:285826-vmul-squashed](https://github.com/mikabl-arm/jdk/tree/285826-vmul-squashed) and merge it to [mikabl-arm:8322770](https://github.com/mikabl-arm/jdk/tree/8322770) (this PR's branch) first? I can address any comments including `type2aelembytes` afterwards. This should make it easier to keep track of changes as now there are two different branches and I feel that this might get confusing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18487#issuecomment-2265647359


More information about the hotspot-dev mailing list