RFR: 8336163: Remove declarations of some debug-only methods in release build [v3]

Vladimir Kozlov kvn at openjdk.org
Fri Aug 2 15:32:35 UTC 2024


On Thu, 1 Aug 2024 08:33:48 GMT, Qizheng Xing <qxing at openjdk.org> wrote:

>> Some of the methods are defined only in debug mode, but their declarations still exist in release mode.
>> 
>> This is considered a bug because these methods may be called mistakenly in release mode and cause the build to fail.
>
> Qizheng Xing has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Merge `#ifndef PRODUCT` regions.

The GHA testing is not activated for this branch. Please fix it.
Even so changes look trivial it should be tested (VM build) on all supported platforms in GHA.

-------------

Changes requested by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20131#pullrequestreview-2215862303


More information about the hotspot-dev mailing list