RFR: 8337788: RISC-V: Cleanup code in MacroAssembler::reserved_stack_check

Fei Yang fyang at openjdk.org
Mon Aug 5 01:09:33 UTC 2024


On Sun, 4 Aug 2024 02:43:26 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi, 
> In the MacroAssembler::reserved_stack_check() function:
> 
>     RuntimeAddress target(StubRoutines::throw_delayed_StackOverflowError_entry());
>     relocate(target.rspec(), [&] {
>       int32_t offset;
>       movptr(t0, target.target(), offset);
>       jr(t0, offset);
>     });
> 
> can be simplified to:
> 
>   la(t0, RuntimeAddress(StubRoutines::throw_delayed_StackOverflowError_entry()));
>   jr(t0);
> 
> 
> In addition, the code formatting has been modified to remove the extra spaces before the code.
> 
> Please take a look and have some reviews. Thanks a lot.
> 
> ### Testing
> - [x] Run tier1-3 tests on SOPHON SG2042 (fastdebug)

Thanks.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20458#pullrequestreview-2217868792


More information about the hotspot-dev mailing list