RFR: 8333791: Fix memory barriers for @Stable fields [v2]
Aleksey Shipilev
shade at openjdk.org
Mon Aug 5 08:11:35 UTC 2024
On Fri, 2 Aug 2024 13:42:57 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Again, the problem here is that new tests are *IR Tests*, and I am struggling to find a good way to bootclasspath the classes that IR Test Framework itself invokes. A develop `RestrictStable` flag is the cleanest approach I could find. The tests you referenced are not IR tests, and so do not have this problem.
>
> IIUC, you want to somehow have `-Xbootclasspath/a:path_to_your_ir_test`. I guess that's currently not so easy to do and probably needs some IR framework support.
>
> I've had a quick look. How about something like that (just prototyped, not fully tested): [ir_framework.patch](https://github.com/user-attachments/files/16471225/ir_framework.log)
>
> Then you could use it like that:
>
> TestFramework testFramework = new TestFramework();
> testFramework
> .addFlags("...", "...")
> .addTestClassesToBootClassPath()
> .start();
>
>
> If that works for all your tests, then you could either add the IR framework changes directly to this patch or we do it in preceding RFE separately.
Yeah, OK, let's do IR Framework update separately. I am planning to have this fix backported, so I would like to have test infra fixes also be more or less cleanly backportable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19635#discussion_r1703710553
More information about the hotspot-dev
mailing list