RFR: 8314125: RISC-V: implement Base64 intrinsic - encoding [v6]

[Hamlin Li]

On Mon, 5 Aug 2024 01:39:39 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - merge master
>>  - Merge branch 'master' into baes64-encode-integrated
>>  - move label
>>  - refine code
>>  - use pure scalar version when rvv is not supported
>>  - clean code
>>  - Initial commit
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 5206:
> 
>> 5204: 
>> 5205:     RegSet saved_regs;
>> 5206:     __ push_reg(saved_regs, sp);
> 
> But `saved_regs` is empty?

good catch, fixed.

> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 5211:
> 
>> 5209:     __ sub(length, send, soff);
>> 5210:     __ mv(t0, 3);
>> 5211:     __ div(length, length, t0);
> 
> Could this `div` be avoided? Maybe we could simply check and update `length` at the byte granunarity.

fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19973#discussion_r1704203299
PR Review Comment: https://git.openjdk.org/jdk/pull/19973#discussion_r1704203258