RFR: 8332120: Potential compilation failure in istream.cpp:205 - loss of data on conversion
Ioi Lam
iklam at openjdk.org
Mon Aug 5 20:54:36 UTC 2024
On Fri, 2 Aug 2024 12:01:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> > Looks like it is for debugging to ensure it does in fact only have the values 0,1, 2.
>
>
>
> do you know why it's useful?
The is vestigial code from the original PR that introduced istream.cpp (see https://github.com/openjdk/jdk/pull/18833)
The original implementation (courtesy @rose00) had many features that weren't needed at the time and we decided to remove them for simplicity. I think it's OK to remove this field as well. We can add it back when needed in the future.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20427#issuecomment-2269898074
More information about the hotspot-dev
mailing list