RFR: 8333356: JVM crashes with "aux_index does not match even or odd indices"

[Coleen Phillimore]

On Thu, 8 Aug 2024 08:32:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/utilities/concurrentHashTable.inline.hpp line 684:
>> 
>>> 682:         DEBUG_ONLY(fatal("Cannot resize table: Node hash code has changed possibly due to corruption of the contents."
>>> 683:                          " Node hash code changed from " SIZE_FORMAT " to " SIZE_FORMAT, aux->saved_hash(), aux_hash));
>>> 684:         fatal("Cannot resize table: Node hash code has changed possibly due to corruption of the contents.");
>> 
>> Wondering if any compiler will flag the second fatal as unreachable?
>
> +1. It would also dedup the messages if we wrap the second concat (yay preprocessor macros):
> 
> 
> fatal("Cannot resize table: Node hash code has changed possibly due to corruption of the contents."
>       DEBUG_ONLY(" Node hash code changed from " SIZE_FORMAT " to " SIZE_FORMAT, aux->saved_hash(), aux_hash));

I tried this dedup for the message and the compiler was displeased.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20503#discussion_r1709724890