RFR: 8338011: CDS archived heap object support for 64-bit Windows [v2]
Ioi Lam
iklam at openjdk.org
Sun Aug 11 21:17:08 UTC 2024
> We didn't support CDS archived heap object on Windows because
>
> - The Windows implementation of `os::map_memory()` cannot map the contents of a file into a region that's already reserved by the garbage collector.
> - We had a high failure rate for mapping the CDS archive on Windows due to ASLR, sometimes as high as 50%. So it didn't seem worth the effort (mainly testing) to support archived heap objects on Windows.
>
> Both of the above issues were fixed in [JDK-8231610](https://bugs.openjdk.org/browse/JDK-8231610), so we should add the support to Windows now.
>
> (Tested on Oracle CI tiers 1-7)
Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
@tstuefe review -- changed error message
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20514/files
- new: https://git.openjdk.org/jdk/pull/20514/files/8c79b888..0745467c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20514&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20514&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/20514.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20514/head:pull/20514
PR: https://git.openjdk.org/jdk/pull/20514
More information about the hotspot-dev
mailing list